Fix! (was: [mICQ] New snapshot!)

[Martin Stubenschrott]

On Thu, Nov 02, 2006 at 11:36:32PM +0100, Rüdiger Kuhlmann wrote:
> For mICQ that means that this is a quick fix:
> 
> Index: src/oscar_roster.c
> ===================================================================
> RCS file: /var/lib/cvs/micq/src/oscar_roster.c,v
> retrieving revision 1.28
> diff -u -r1.28 oscar_roster.c
> --- src/oscar_roster.c  23 Sep 2006 21:03:22 -0000      1.28
> +++ src/oscar_roster.c  2 Nov 2006 22:28:05 -0000
> @@ -117,6 +117,7 @@
>      SnacCliReady (serv);
>      SnacCliAddcontact (serv, NULL, serv->contacts);
>      SnacCliReqofflinemsgs (serv);
> +    SnacCliReqinfo (serv);
>      if (serv->flags & CONN_WIZARD)
>      {
>          IMRoster (serv, IMROSTER_IMPORT);
> 
> 
> 
> Seems the SNAC(1,0xf) has also changed, it gives a seemingly benign warning
> about a broken TLV from mICQ. I made a new snapshot with it in it, plus
> a fix for the core dump found by Dobromir Velev that was introduced by my
> changes to the contact list functions that I did for Jabber. Enjoy.

Thanks, sending messages works now again :)

But after starting from scratch without a .micqrc/status file, and
trying to:

contact download

I get this:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1480485200 (LWP 16321)]
0xa7cd23ca in strcmp () from /lib/libc.so.6
(gdb) bt
#0  0xa7cd23ca in strcmp () from /lib/libc.so.6
#1  0x08065171 in ContactAddAlias (cont=0x8157328, nick=0x0, 
    debugfile=0x80b8c88 "im_icq8.c", debugline=322) at contact.c:622
#2  0x080a4a84 in IMRosterDownCont (serv=0x80f6718, roster=<value optimized out>, 
    cg=0x81595c8, rc=0x8152a30, pcnt=0xaff34a8c, pmod=0xaff34a7c, force=0 '\0', flag=0)
    at im_icq8.c:322
#3  0x080a63d7 in IMRosterAdddown (event=0x811f9e8) at im_icq8.c:362
#4  0x0809feaf in SnacSrvReplyroster (event=0x81573b8) at oscar_roster.c:307
#5  0x0809848a in SnacCallback (event=0x81573b8) at oscar_snac.c:154
#6  0x08060004 in QueueRun (debugfile=0x80a90b7 "micq.c", debugline=629)
    at msg_queue.c:545
#7  0x08058274 in main (argc=1, argv=0xaff35d14) at micq.c:629


Thanks anyway for the quick fix,

--
Martin